Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: zookeeper reduce image size #1043

Merged
merged 8 commits into from
Apr 9, 2025
Merged

Fix: zookeeper reduce image size #1043

merged 8 commits into from
Apr 9, 2025

Conversation

maltesander
Copy link
Member

@maltesander maltesander commented Mar 27, 2025 •
edited
Loading

Description

part of #961

REPOSITORY                               TAG                                   IMAGE ID       CREATED          SIZE
oci.stackable.tech/sdp/zookeeper         3.9.3-stackable25.3.0-reduced-size    0cdaed351a1c   5 minutes ago    553MB
oci.stackable.tech/sdp/zookeeper         3.9.3-stackable25.3.0                 c39102329a46   2 days ago       577MB
  • Does remove the recursive chmod/chown in the final image and attempts non recursive chmod/chown or doing as much as possible in the builder step.
  • removed log4shell check
  • Uses check-permissions-ownership script to validate any wrong permissions / ownership in the /stackable folder (example for nifi)
 => [nifi-2_2_0 final  7/10] RUN <<EOF (microdnf update...)                                                                                                                                         8.2s
 => ERROR [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...)                                                                                                         0.9s
------
 > [nifi-2_2_0 final  8/10] RUN <<EOF (chmod +x /tmp/check-permissions-ownership...):
0.601 Ownership mismatch:  /stackable/nifi (Expected: 1000:0, Found: 0:0)
0.622 Permission mismatch: /stackable/python (Owner: rwx, Group: r-x)
0.624 Permission mismatch: /stackable/bin (Owner: rwx, Group: r-x)
0.628 Permission mismatch: /stackable/nifi-2.2.0 (Owner: rwx, Group: r-x)
0.843 Permission and Ownership checks failed for /stackable!

@maltesander maltesander self-assigned this Mar 27, 2025
@maltesander maltesander mentioned this pull request Mar 27, 2025
Closed
@maltesander maltesander marked this pull request as ready for review March 27, 2025 14:36
@maltesander maltesander moved this to Development: Waiting for Review in Stackable Engineering Mar 27, 2025
@siegfriedweber siegfriedweber self-requested a review April 9, 2025 08:52
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Apr 9, 2025
siegfriedweber
siegfriedweber previously approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maltesander maltesander added this pull request to the merge queue Apr 9, 2025
@maltesander maltesander moved this from Development: In Review to Development: Done in Stackable Engineering Apr 9, 2025
Merged via the queue into main with commit ceaa1cd Apr 9, 2025
3 checks passed
@maltesander maltesander deleted the fix/zookeeper-reduce-image-size branch April 9, 2025 09:34
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@maltesander maltesander

Labels
None yet
Projects
Stackable Engineering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maltesander @siegfriedweber